Ticket #79 (closed defect: fixed)

Opened 4 months ago

Last modified 4 months ago

Range check error file pwm.c line 79

Reported by: rmann Owned by:
Priority: major Milestone:
Component: firmware Keywords:
Cc:

Description

Here's some context:

int Pwm_Set( int index, int duty ) {

if ( index < 0 index > PWM_COUNT )

return CONTROLLER_ERROR_ILLEGAL_INDEX;

PWM_COUNT is 4, which means this test would allow values 0 - 4 to be passed. Really the range allowed should be 0-3.

Change History

Changed 4 months ago by liamMT

  • status changed from new to closed
  • resolution set to fixed

Resolved in rev [874] - thanks for the report.

I also notice that your line numbers don't correspond very closely to the latest version...not a huge deal in this case as it was easy to find, but might be helpful in the future to specify which version you're referencing.

Changed 4 months ago by rmann

Oh, it's some version out of SVN. That's why I gave the context.

Note: See TracTickets for help on using tickets.